Fix drawdown label checks in PerformanceMetrics class - #7
Open
Yosri-Ben-Halima wants to merge 3 commits into
Open
Yosri-Ben-Halima wants to merge 3 commits into
Yosri-Ben-Halima wants to merge 3 commits into
Conversation
Owner
|
@yosri-bh can we please include specific versions of packages in requirements.txt? For example, instead of seaborn~=0.13.2 we have seaborn==0.13.2 This helps with the stability of the solution. Can you also please edit this example usage if needed, because currently it doesn't show the Alpha and Beta graphs properly? Also, I don't think the metrics report is shown as you intended. |
added 2 commits
November 17, 2025 23:02
…rading-utilities into hotfix-drawdown-duration-formatting
…to match versions in local venv for consistency
Yosri-Ben-Halima
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update label checks to include "Max Drawdown" and "Average Drawdown" for accurate performance formatting.