fix: fix prosemirror version mismatches#1242
Merged
Merged
Conversation
3mcd
added a commit
that referenced
this pull request
May 15, 2025
* feat: first attempt at adding prosemirror-tables * feat: add columnResizing plugin * chore: more table work * feat: make tables prettier * feat: remove alternating background * chore: bump prosemirror view * feat: get tabbing working * feat: add figure * feat: make it look a lil more like allison's * chore: downgrade prosemirror-view * feat: toggle function * keep panel open when title/caption toggled * get marks working * simplify * simplify * css * fix up media upload * credit and license * fix type error * remove unused code * remove more unused code * dont open by default * fix: fix some node playwright tests * fix: make the media playwright tests fail later * a little cleanup * restore closing behavior * fix: fix prosemirror version mismatches (#1242) * fix: fix prosemirror version mismatches * chore: remove ts-expect-error * fix type error * more cleanup * typerror * fix toggle test * table resizing works now yay * fix key issue * try testid * try blur * open advanced * expand advanced options * fix mark attr updates * resolve closest node to cursor for attributepanel * try this * force test run * active node is node after from and node before to * try state.selection. instead of anchor * fix a couple more tests * try this * try doubleclick * dblclick * try dblclick again * nullish form control * redundant click * remove id and class from MediaUpload menu * add form * Update packages/context-editor/src/style.css Co-authored-by: Thomas F. K. Jorna <hello@tefkah.com> * Update packages/context-editor/src/style.css Co-authored-by: Thomas F. K. Jorna <hello@tefkah.com> * Update packages/context-editor/src/style.css Co-authored-by: Thomas F. K. Jorna <hello@tefkah.com> --------- Co-authored-by: Thomas F. K. Jorna <hello@tefkah.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
ProseMirror versions have somewhat diverged. this would cause an issue when inserting math in tables because you would get a ProseMirror model is not the same error. this PR fixes that by updating most of our prosemirror-related packages to the latest versions and pinning the most variable versions in the catalog. This includes
@handlewithcare/react-prosemirrorwhich should fix this issue handlewithcarecollective/react-prosemirror#51 raised by @allisonkingHigh-level Explanation of PR
Test Plan
Screenshots (if applicable)
Notes