feat: simple editor tables#1190
Conversation
| "prosemirror-tables": "^1.7.1", | ||
| "prosemirror-transform": "^1.10.0", | ||
| "prosemirror-view": "1.37.1", | ||
| "prosemirror-view": "1.39.2", |
There was a problem hiding this comment.
I think we actually need this at 1.37.1 per https://github.com/handlewithcarecollective/react-prosemirror?tab=readme-ov-file#installation
Note: React ProseMirror releases are coupled to specific prosemirror-view releases, and are not guaranteed to work with other versions of prosemirror-view. Ensure that your version of prosemirror-view matches the version in React ProseMirror's peer dependencies!
There was a problem hiding this comment.
Hmmm okay. Everything seems to work with the bump, but I'll revert this change and silence the type errors I was getting.
|
was the goal to incorporate the designs that @ktyjscott shared here? https://knowledgefutures.slack.com/archives/CMAQM0BNV/p1741115441929979 i did not see it mentioned in the ticket, so maybe that was missed, but if it was skipped intentionally ofc ignore me! |
|
@tefkah Good question. I am omitting the precise table styling and interactivity, instead opting to just get a basic prosemirror-tables integration working. I'll also add the attributes menu for the title and caption. But all of the additional commands from the context menu, table resizing, etc should be considered OOS for this PR. |
f8525ae to
6059fe9
Compare
allisonking
left a comment
There was a problem hiding this comment.
I think it looks great for a first pass! sorry for the merge conflicts 🙈
Co-authored-by: Thomas F. K. Jorna <hello@tefkah.com>
Co-authored-by: Thomas F. K. Jorna <hello@tefkah.com>
Co-authored-by: Thomas F. K. Jorna <hello@tefkah.com>
Issue(s) Resolved
Partial #1108, will add a follow-up PR for title and captions when #1177 lands.
High-level Explanation of PR
TODO: tests
tableEditingplugin to our plugin list.I also did some (fairly tame) refactoring of the way we track the active node that hopefully is a bit easier to understand and a little more fault-tolerant.
Test Plan
Screenshots (if applicable)
A table!
Notes
columnResizingplugin currently breaks the editor, so it's disabled for now.