Skip to content

Add default text for form links #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3mcd merged 3 commits into from
May 5, 2025
Merged

Add default text for form links #1222

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
974b002
Add default text for form links
allisonking May 1, 2025
8a6a6a3
Update comment
allisonking May 1, 2025
86b9e33
Merge branch 'main' into aking/1148/email-invitation-links
3mcd May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/lib/server/render/pub/renderMarkdownWithPub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,14 @@ const renderMarkdownWithPubPlugin: Plugin<[utils.RenderWithPubContext]> = (conte
communityId: context.communityId,
pubId: context.pub.id as PubsId,
});
assert(isParent(node));
// Include default text
node.children = [
{
type: "text",
value: attrs.text ?? props.href,
},
];
Comment on lines +267 to +274

@allisonking allisonking May 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copied from

https://github.com/pubpub/platform/blob/974b002ee13d1d61accf775c06e13cf226dacd2d/core/lib/server/render/pub/renderMarkdownWithPub.ts#L168-L174

in visitLinkDirective. However, the href at this point is just an empty string because this defers the creation of the link to further down in the file

https://github.com/pubpub/platform/blob/974b002ee13d1d61accf775c06e13cf226dacd2d/core/lib/server/render/pub/renderMarkdownWithPub.ts#L261-L266

I'm not sure if there's a way we can reuse what was already there, but I'm guessing not since this exception for form links was already carved out.

}
}
})
Expand Down