Add default text for form links#1222
Merged
Merged
Conversation
allisonking
commented
May 1, 2025
Comment on lines
+267
to
+274
| assert(isParent(node)); | ||
| // Include default text | ||
| node.children = [ | ||
| { | ||
| type: "text", | ||
| value: attrs.text ?? props.href, | ||
| }, | ||
| ]; |
Contributor
Author
There was a problem hiding this comment.
this is copied from
in visitLinkDirective. However, the href at this point is just an empty string because this defers the creation of the link to further down in the file
I'm not sure if there's a way we can reuse what was already there, but I'm guessing not since this exception for form links was already carved out.
3mcd
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Closes #1148
High-level Explanation of PR
Make sure we still include some texts for form links. This wasn't working for forms because we figure out their links (with auth tokens) later in the flow, and the logic that defaults to the link occurs earlier than when the forms get their links.
Test Plan
Follow steps in the issue, but your email should have some text.
Screenshots (if applicable)
With
:link{form="review"}With
:link{form="review" text="test"}Notes