feat: simple editor tables #1190
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import type { EditorState } from "prosemirror-state"; | ||
|
|
||
| import { Fragment, Node } from "prosemirror-model"; | ||
| import { NodeSelection } from "prosemirror-state"; | ||
|
|
||
| import { assert } from "utils"; | ||
|
|
||
| import type { Dispatch } from "./types"; | ||
|
|
||
| const nodeTypes = ["title", "figcaption", "credit", "license"] as const; | ||
| const nodeSlots = [ | ||
| "title", | ||
| // (child) | ||
| "table", | ||
| "image", | ||
| // (/child) | ||
| "figcaption", | ||
| "credit", | ||
| "license", | ||
| ] as const; | ||
| type ToggleableNodeType = (typeof nodeTypes)[number]; | ||
|
|
||
| const errNodeNotResolved = "Node not resolved at position"; | ||
| const errNodeNotFigure = "Node is not a figure node"; | ||
| const errNodeContentInvalid = "Node has invalid content"; | ||
|
|
||
| export const toggleFigureNode = | ||
| (state: EditorState, dispatch?: Dispatch) => | ||
| (position: number, nodeType: ToggleableNodeType) => { | ||
| const figurePosition = state.doc.resolve(position); | ||
| const figureNode = figurePosition.nodeAfter; | ||
| assert(figureNode !== null, errNodeNotResolved); | ||
| assert(figureNode.type.name === "figure", errNodeNotFigure); | ||
| const sparseContent: (Node | undefined)[] = []; | ||
|
Collaborator
Author
There was a problem hiding this comment. I use a sparse array here to ensure each element is in the proper order. First I fill in the array like [title, image]
[, table, figcaption]
[, image, , , credit]
// etcThen remove all the holes in the array. This could be done by pushing each existing node into a new array, but if the figure's children ever got out of sync with the |
||
|
|
||
| let insert = true; | ||
| figureNode.content.forEach((node) => { | ||
| if (node.type.name !== nodeType) { | ||
| const slot = nodeSlots.findIndex((name) => name === node.type.name); | ||
| assert(slot > -1, errNodeContentInvalid); | ||
| sparseContent[slot] = node; | ||
| } else { | ||
| insert = false; | ||
| } | ||
| }); | ||
|
|
||
| if (insert) { | ||
| const slot = nodeSlots.findIndex((name) => name === nodeType); | ||
| sparseContent[slot] = figureNode.type.schema.nodes[nodeType].create(); | ||
| } | ||
|
|
||
| // remove holes in the array | ||
| const content = sparseContent.filter((node) => node !== undefined) as Node[]; | ||
|
|
||
| // replace the figure node with the new content | ||
| const newFigureNode = figureNode.type.create( | ||
| figureNode.attrs, | ||
| Fragment.fromArray(content), | ||
| figureNode.marks | ||
| ); | ||
|
|
||
| if (dispatch) { | ||
| const tr = state.tr.replaceWith( | ||
| figurePosition.pos, | ||
| figurePosition.pos + figureNode.nodeSize, | ||
| newFigureNode | ||
| ); | ||
| const selection = NodeSelection.create(tr.doc, tr.mapping.map(figurePosition.pos)); | ||
| tr.setSelection(selection); | ||
| dispatch(tr); | ||
| } | ||
|
|
||
| return true; | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this version of prosemirror tables uses a different version of
prosemirror-modelthen we have been using. this causes errors when eg using math inside of a table.i fixed this here: #1242