Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): add deprecation warning for tracking datatsets #955

Merged
merged 4 commits into from
Dec 2, 2024
Merged

feat(datasets): add deprecation warning for tracking datatsets #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e36bcd
add deprecation warning for tracking datatsets
Dec 2, 2024
2fd629c
update release note
Dec 2, 2024
1437286
Update kedro-datasets/RELEASE.md
Huongg Dec 2, 2024
21b8ab0
Fix linting
merelcht Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kedro-datasets/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
## Bug fixes and other changes
- Implemented Snowflake's (local testing framework)[https://docs.snowflake.com/en/developer-guide/snowpark/python/testing-locally] for testing purposes
- Improved the dependency management for Spark-based datasets by refactoring the Spark and Databricks utility functions used across the datasets.
- Add deprecation warning for `tracking.MetricsDataset` and `tracking.JSONDataset`.

## Breaking Changes
- Demoted `video.VideoDataset` from core to experimental dataset.
Expand Down
9 changes: 9 additions & 0 deletions kedro-datasets/kedro_datasets/tracking/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
"""Dataset implementations to save data for Kedro Experiment Tracking."""

import warnings
from typing import Any

import lazy_loader as lazy

from kedro_datasets import KedroDeprecationWarning

# https://github.com/pylint-dev/pylint/issues/4300#issuecomment-1043601901
JSONDataset: Any
MetricsDataset: Any
Expand All @@ -15,3 +18,9 @@
"metrics_dataset": ["MetricsDataset"],
},
)

warnings.warn(
"`tracking.JSONDataset` and `tracking.MetricsDataset` are deprecated. These datasets will be removed in kedro-datasets 7.0.0",
KedroDeprecationWarning,
stacklevel=2,
)
Loading