Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): add deprecation warning for tracking datatsets #955

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Dec 2, 2024

Description

Fixes #954

This PR is to add the deprecation warning for MetricsTrackingDataset and JSONTrackingDataset as it will be removed soon in the next release

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@Huongg Huongg mentioned this pull request Dec 2, 2024
7 tasks
Signed-off-by: Huong Nguyen <[email protected]>
kedro-datasets/RELEASE.md Outdated Show resolved Hide resolved
Co-authored-by: Merel Theisen <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

To fix the linting, you'll have to run make plugin=kedro=datasets lint from the kedro-plugins directory locally.

Signed-off-by: Merel Theisen <[email protected]>
@Huongg Huongg merged commit f7a65c5 into main Dec 2, 2024
12 of 13 checks passed
@Huongg Huongg deleted the feature/add-deprecation-warning-for-tracking-datasets branch December 2, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kedro-datasets: Add deprecation warning for MetricsTrackingDataset and JSONTrackingDataset
3 participants