Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ enable_testing()
include(FetchContent)
FetchContent_Declare(salal
GIT_REPOSITORY https://github.com/kcjonson/salal.git
GIT_TAG v0.15.0
GIT_TAG v0.17.0
GIT_SHALLOW TRUE
)
set(SALAL_BUILD_UI OFF)
Expand Down
4 changes: 2 additions & 2 deletions docs/technical/include-graph.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ node tools/resolve-includes.mjs --root path/to/another/checkout

## Baseline

Production files only (test and bench files excluded), at the change that runs worldsim's GUI apps on salal's `App` (2026-10-28), with foundation, renderer and app read from salal v0.15.0. app has a row and a column now: worldsim builds salal's app library and engine links it. Against main @ f6f80cdc, the same pin, read by this version of the script (which gives main's rows as before, plus app's, and one ambiguity: salal's `application/App.h` includes `"application/AppConfig.h"`, which engine's own `libs/engine/application/AppConfig.h` also answered), deleting `libs/engine/{application,scene,input,clipboard,debug}` took engine -> engine from 461 to 449, engine -> external from 522 to 456, engine -> foundation from 50 to 44 and engine -> renderer from 29 to 19, and the bridge in `libs/engine/app` adds engine -> app 5 (`UiScene.h`, `UiOverlay.h`, `UiClipboard.h`, `UiBridge.h` and `UiBridge.cpp` include salal's `scene/Scene.h`, `scene/Overlay.h`, `clipboard/Clipboard.h`, `DevServer/DevServer.h` and `application/App.h`). engine -> ui stays at 5, all in the bridge now: `focus/FocusManager.h`, `clipboard/IClipboard.h`, `input/InputEvent.h`, `debug/LayoutLint.h` and `debug/UiTreeSerializer.h`, where it was Application, AppLauncher, SceneManager and ClipboardManager's. In the all-files matrix engine -> engine went from 706 to 695, engine -> external from 775 to 716, engine -> foundation from 56 to 50, engine -> renderer from 35 to 25 and engine -> ui from 6 to 10 (the deleted `DebugServer.test.cpp` and `InputManager.test.cpp` went with the rest, `FontAtlases.test.cpp` moved into `libs/engine/app/`, and `UiBridge.test.cpp` there runs the bridge on salal's headless platform), and engine -> app is 7. Rows are the including library, columns the library the include lands in.
Production files only (test and bench files excluded), at the change that runs worldsim's GUI apps on salal's `App` (2026-10-28), with foundation, renderer and app read from salal v0.17.0. app has a row and a column now: worldsim builds salal's app library and engine links it. Against main @ f6f80cdc, read at salal v0.15.0 by this version of the script (which gives main's rows as before, plus app's, and one ambiguity: salal's `application/App.h` includes `"application/AppConfig.h"`, which engine's own `libs/engine/application/AppConfig.h` also answered), deleting `libs/engine/{application,scene,input,clipboard,debug}` took engine -> engine from 461 to 449, engine -> external from 522 to 456, engine -> foundation from 50 to 44 and engine -> renderer from 29 to 19, and the bridge in `libs/engine/app` adds engine -> app 5 (`UiScene.h`, `UiOverlay.h`, `UiClipboard.h`, `UiBridge.h` and `UiBridge.cpp` include salal's `scene/Scene.h`, `scene/Overlay.h`, `clipboard/Clipboard.h`, `DevServer/DevServer.h` and `application/App.h`). engine -> ui stays at 5, all in the bridge now: `focus/FocusManager.h`, `clipboard/IClipboard.h`, `input/InputEvent.h`, `debug/LayoutLint.h` and `debug/UiTreeSerializer.h`, where it was Application, AppLauncher, SceneManager and ClipboardManager's. In the all-files matrix engine -> engine went from 706 to 695, engine -> external from 775 to 716, engine -> foundation from 56 to 50, engine -> renderer from 35 to 25 and engine -> ui from 6 to 10 (the deleted `DebugServer.test.cpp` and `InputManager.test.cpp` went with the rest, `FontAtlases.test.cpp` moved into `libs/engine/app/`, and `UiBridge.test.cpp` there runs the bridge on salal's headless platform), and engine -> app is 7. The pin then moved from salal v0.15.0 to v0.17.0, which adds `primitives/BoundaryLoops.{h,cpp}`: renderer -> foundation went from 33 to 34 (`math/Types.h`), renderer -> renderer from 96 to 99 (the `.cpp`'s include of its header, and `BatchRenderer.cpp` and `Primitives.cpp` including it) and renderer -> external from 204 to 216 (the standard headers of `BoundaryLoops.{h,cpp}`, and `<cassert>`, `<cstddef>`, `<utility>` in `Stroke.cpp` and `<array>`, `<cstddef>`, `<cstdint>` in `Stroke.h`); no other production cell moved. In the all-files matrix the same row went from 41 to 42, 155 to 163 and 354 to 382 with the new tests (`BoundaryLoops.test.cpp`, `Flush.test.cpp`, `Primitives.test.cpp` and the larger `Stroke.test.cpp` and `BatchRenderer.test.cpp`). Rows are the including library, columns the library the include lands in.

| src \ dst | foundation | geometry | renderer | ui | world | planet-view | game-systems | app | engine | engine(assets) | external |
|---|---|---|---|---|---|---|---|---|---|---|---|
| foundation | 16 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 110 |
| geometry | 2 | 86 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 158 |
| renderer | 33 | 0 | 96 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 204 |
| renderer | 34 | 0 | 99 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 216 |
| ui | 97 | 0 | 43 | 158 | 0 | 0 | 0 | 0 | 0 | 0 | 117 |
| world | 34 | 0 | 0 | 0 | 118 | 0 | 0 | 0 | 0 | 0 | 149 |
| planet-view | 2 | 0 | 1 | 0 | 6 | 11 | 0 | 0 | 0 | 0 | 38 |
Expand Down
Loading