Skip to content

Pin salal v0.17.0 - #315

Merged
kcjonson merged 2 commits into
mainfrom
chore/SAL-89-salal-v0.17.0
Oct 28, 2026
Merged

kcjonson merged 2 commits into
mainfrom
chore/SAL-89-salal-v0.17.0

Conversation

@kcjonson

Copy link
Copy Markdown
Owner

Pin

salal v0.15.0 to v0.17.0 in the root CMakeLists.txt, and the include graph doc refreshed (the renderer row moved: salal's new BoundaryLoops.{h,cpp}). No source file needed a change.

What changed in salal

  • v0.16.0 deletes Primitives::setFrameUpdateCallback (not called here) and updates docs.
  • v0.17.0 (salal#34) partitions strokes so each pixel is drawn once, adds a feather ring to drawPolygon fills, adds an opt-in TrianglesArgs::antiAlias (default off), and gives a zero-size box defined coverage in the base shader. Worldsim calls none of drawPolygon, drawPolyline or drawArc and builds TrianglesArgs with designated initializers, so no pixel should move.

Comparison

Debug builds, main 818f3dff (v0.15.0) against this branch (v0.17.0), two frames of each build for the noise floor.

capture before vs after one build, two frames
ui-sandbox text_shapes, svg, button, grass, textwrap, planet, layout, treeview, icon identical identical
world-sim main menu (globe included, 3 launches each) identical identical
asset-manager browser identical identical
world-sim game, paused max delta 4 outside the colonist and its minimap marker max 10 (before), 11 (after)
asset-cli BigRock, Colonist, Flora_TreeMaple x3 byte-identical

In the game, 4,310 of 5,184 32-px cells are byte-identical; the rest are the river and wind animation (below the frame-to-frame floor) and the wandering colonist with its minimap marker. The clock reads 06:15 in both. The ui trees and lint reports are byte-identical in every scene.

Tests

ctest --test-dir build -C Debug: 13/13 passed.

@kcjonson
kcjonson marked this pull request as ready for review October 28, 2026 15:44
Copilot AI balanced review requested due to automatic review settings October 28, 2026 15:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@kcjonson
kcjonson merged commit f909ba5 into main Oct 28, 2026
10 checks passed
@kcjonson
kcjonson deleted the chore/SAL-89-salal-v0.17.0 branch October 28, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants