Repository navigation
Pin salal v0.17.0 - #315
Merged
Merged
Conversation
kcjonson
marked this pull request as ready for review
October 28, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin
salal v0.15.0 to v0.17.0 in the root
CMakeLists.txt, and the include graph doc refreshed (the renderer row moved: salal's newBoundaryLoops.{h,cpp}). No source file needed a change.What changed in salal
Primitives::setFrameUpdateCallback(not called here) and updates docs.drawPolygonfills, adds an opt-inTrianglesArgs::antiAlias(default off), and gives a zero-size box defined coverage in the base shader. Worldsim calls none ofdrawPolygon,drawPolylineordrawArcand buildsTrianglesArgswith designated initializers, so no pixel should move.Comparison
Debug builds, main
818f3dff(v0.15.0) against this branch (v0.17.0), two frames of each build for the noise floor.text_shapes,svg,button,grass,textwrap,planet,layout,treeview,iconIn the game, 4,310 of 5,184 32-px cells are byte-identical; the rest are the river and wind animation (below the frame-to-frame floor) and the wandering colonist with its minimap marker. The clock reads 06:15 in both. The ui trees and lint reports are byte-identical in every scene.
Tests
ctest --test-dir build -C Debug: 13/13 passed.