Add E2E tests for Services/Ingress in the dashboard

[SunsetB612]

No description provided.

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @SunsetB612, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the dashboard's end-to-end testing suite by removing several older tests related to Kubernetes Namespace management and introducing a new test focused on listing CronJobs. The changes also include the addition of the official Kubernetes client library for Node.js, which could enable more direct programmatic interaction with Kubernetes clusters within the dashboard's ecosystem.

Highlights

• E2E Test Refactoring: Removed existing Playwright E2E tests for Namespace creation, deletion, and network error handling, indicating a shift in testing strategy for these components.
• CronJob E2E Test Introduction: Refactored the Namespace listing E2E test into a new test for listing CronJobs under the 'Workloads' section, including updated navigation and assertions to verify CronJob display.
• New Dependency Added: Introduced the @kubernetes/client-node library as a new dependency, suggesting potential future direct interaction with Kubernetes APIs from the dashboard or its testing utilities.
• Dependency Updates: Updated the pnpm-lock.yaml file to reflect the new Kubernetes client dependency and various other package updates, including a bump in the @types/node version.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds an end-to-end test for the CronJob list page, which is a good addition. However, there are a few points that need clarification. The pull request title, 'Add E2E tests for Services/Ingress in the dashboard', is misleading as the changes are related to CronJobs and Namespaces, not Services or Ingress. Please update the title to accurately reflect the content of this PR. More importantly, several E2E tests for Namespaces have been removed without explanation. Since the Namespace feature still seems to exist, removing its tests is a significant concern and should be addressed. I've added comments on the removed files regarding this. Lastly, a minor issue was found in the new test file where some variable names and comments from a copy-paste were not updated.

[gemini-code-assist]

This test file for creating namespaces has been removed. Since the namespace creation functionality appears to still exist, removing tests is a significant risk. Could you please provide a justification for this removal or restore the test?

[gemini-code-assist]

This test file for deleting namespaces has been removed. Since the namespace deletion functionality appears to still exist, removing tests is a significant risk. Could you please provide a justification for this removal or restore the test?

[gemini-code-assist]

This test file for namespace network error handling has been removed. Removing tests for error handling scenarios is risky. Could you please provide a justification for this removal or restore the test?

[gemini-code-assist]

The variable names and comments in this section seem to be copied from a StatefulSet test and were not updated for CronJob. This can be confusing for future maintenance. Please update them to reflect that this test is for CronJobs.

Suggested change

	// 点击可见的 Statefulset tab
	const statefulsetTab = page.locator('role=option[name="Cronjob"]');
	await statefulsetTab.waitFor({ state: 'visible', timeout: 30000 });
	await statefulsetTab.click();
	// 验证选中状态
	await expect(statefulsetTab).toHaveAttribute('aria-selected', 'true');
	// 验证 StatefulSet 列表表格可见
	// 点击可见的 Cronjob tab
	const cronjobTab = page.locator('role=option[name="Cronjob"]');
	await cronjobTab.waitFor({ state: 'visible', timeout: 30000 });
	await cronjobTab.click();
	// 验证选中状态
	await expect(cronjobTab).toHaveAttribute('aria-selected', 'true');
	// 验证 Cronjob 列表表格可见

[SunsetB612]

/hold

[SunsetB612]

/unhold