Add E2E tests for Workloads/Cronjob in the dashboard #257

SunsetB612 · 2025-09-10T03:31:53Z

No description provided.

gemini-code-assist

Summary of Changes

Hello @SunsetB612, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the dashboard's End-to-End testing suite. The focus has shifted from testing Namespace management functionalities to establishing E2E coverage for Workloads, specifically Cronjobs. This change also introduces the capability for E2E tests to interact directly with the Kubernetes API, enhancing the reliability and scope of automated testing.

Highlights

Removed Namespace E2E Tests: All existing End-to-End (E2E) tests related to Namespace creation, deletion, and network error handling have been removed from the dashboard's test suite.
Added Cronjob E2E List Test: The E2E test for listing Namespaces has been refactored and repurposed to now test the listing functionality for Cronjobs within the dashboard's Workloads section.
Introduced Kubernetes Client Library: The @kubernetes/client-node library has been added as a dependency, enabling more direct programmatic interaction with Kubernetes APIs within the E2E test environment. This suggests a more robust approach to test setup and verification.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces end-to-end tests for the CronJob workload in the dashboard. It achieves this by repurposing an existing namespace test file and removing other obsolete namespace-related tests. Additionally, it updates dependencies, notably adding @kubernetes/client-node. My review focuses on improving the maintainability of the new test code. I've suggested changes to variable names and comments to make them more accurate and less confusing.

gemini-code-assist · 2025-09-10T03:33:06Z

ui/apps/dashboard/e2e/workload/cronjob/cronjob-list.spec.ts

+    // 点击可见的 Statefulset tab
+    const statefulsetTab = page.locator('role=option[name="Cronjob"]');
+    await statefulsetTab.waitFor({ state: 'visible', timeout: 30000 });
+    await statefulsetTab.click();
+
+    // 验证选中状态
+    await expect(statefulsetTab).toHaveAttribute('aria-selected', 'true');
+
+
+    // 验证 StatefulSet 列表表格可见


The variable name statefulsetTab is misleading as it's being used to locate the 'Cronjob' tab. The comments in this block are also inconsistent, referring to 'Statefulset' instead of 'Cronjob'. To improve code clarity and maintainability, I suggest renaming the variable to cronjobTab and updating the comments to correctly refer to 'Cronjob'.

Suggested change

// 点击可见的 Statefulset tab

const statefulsetTab = page.locator('role=option[name="Cronjob"]');

await statefulsetTab.waitFor({ state: 'visible', timeout: 30000 });

await statefulsetTab.click();

// 验证选中状态

await expect(statefulsetTab).toHaveAttribute('aria-selected', 'true');

// 验证 StatefulSet 列表表格可见

// 点击可见的 Cronjob tab

const cronjobTab = page.locator('role=option[name="Cronjob"]');

await cronjobTab.waitFor({ state: 'visible', timeout: 30000 });

await cronjobTab.click();

// 验证选中状态

await expect(cronjobTab).toHaveAttribute('aria-selected', 'true');

// 验证 Cronjob 列表表格可见

XiShanYongYe-Chang

The tests related to the namespace have been removed, is this the intended?

Additionally, can the tests related to statefulset be removed?

ui/apps/dashboard/playwright.config.ts

SunsetB612 · 2025-09-12T08:38:31Z

The tests related to the namespace have been removed, is this the intended?

Additionally, can the tests related to statefulset be removed?

Oh I removed the namespace-related tests so that this PR only contains the cronjob-related tests, making it clearer. I will also remove the statefulset-related tests in this PR later.

warjiang · 2025-09-22T16:49:18Z

@SunsetB612 is this PR ready to review, it seems that there still some common problems as daemonset/deplyment e2e test.

ui/apps/dashboard/e2e/test-utils.ts

warjiang · 2025-09-25T16:40:40Z

ui/apps/dashboard/e2e/workload/cronjob/cronjob-create.spec.ts

+            }
+        }
+    }, testCronJobYaml);
+    /* eslint-enable */


any better solution for duplicate code 🤔

warjiang · 2025-09-25T16:42:26Z

ui/apps/dashboard/e2e/workload/cronjob/cronjob-edit.spec.ts

+            }
+        }
+    }, modifiedYaml);
+    /* eslint-enable */


warjiang · 2025-09-25T16:45:38Z

@SunsetB612 for the problem of any, it must be corrected. for the problem of duplicate code, you can have a try to resolve the problem

warjiang · 2025-09-26T16:00:08Z

ui/apps/dashboard/e2e/test-utils.ts

+
+type ApiConstructor<T> = new (config: Configuration, ...args: any[]) => T;

 // Set webServer.url and use.baseURL with the location of the WebServer


why not import it directly, like

import {ApiConstructor} from '@kubernetes/client-node';

warjiang · 2025-09-26T16:07:39Z

ui/apps/dashboard/e2e/workload/deployment/test-utils.ts

 export async function createK8sDeployment(yamlContent: string): Promise<void> {
    try {
-        const k8sApi = createKarmadaApiClient();
+        const k8sApi = createKarmadaApiClient(k8s.AppsV1Api);


Signed-off-by: SunsetB612 <[email protected]>

warjiang · 2025-09-27T12:14:27Z

/lgtm
/approve

karmada-bot · 2025-09-27T12:14:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [warjiang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot requested review from jhnine and samzong September 10, 2025 03:31

karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 10, 2025

gemini-code-assist bot reviewed Sep 10, 2025

View reviewed changes

XiShanYongYe-Chang mentioned this pull request Sep 10, 2025

[Summer OSPP 2025] Introduce E2E for the Karmada Dashboard #261

Closed

18 tasks

karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 12, 2025

XiShanYongYe-Chang reviewed Sep 12, 2025

View reviewed changes

ui/apps/dashboard/playwright.config.ts Show resolved Hide resolved

SunsetB612 force-pushed the add-e2e-workload-cronjob branch 2 times, most recently from 0a166f9 to 63f2ec5 Compare September 18, 2025 14:10

karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 18, 2025

SunsetB612 force-pushed the add-e2e-workload-cronjob branch 4 times, most recently from b0d27a2 to bedd380 Compare September 25, 2025 11:23

warjiang reviewed Sep 25, 2025

View reviewed changes

ui/apps/dashboard/e2e/test-utils.ts Outdated Show resolved Hide resolved

warjiang reviewed Sep 25, 2025

View reviewed changes

ui/apps/dashboard/e2e/workload/cronjob/cronjob-edit.spec.ts

}

}

}, modifiedYaml);

/* eslint-enable */

Copy link

Contributor

warjiang Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

SunsetB612 force-pushed the add-e2e-workload-cronjob branch 2 times, most recently from 51eeb45 to 7ae82f2 Compare September 26, 2025 10:25

warjiang reviewed Sep 26, 2025

View reviewed changes

Add E2E tests for Workloads/Cronjob in the dashboard

36d70b0

Signed-off-by: SunsetB612 <[email protected]>

SunsetB612 force-pushed the add-e2e-workload-cronjob branch from 7ae82f2 to 36d70b0 Compare September 27, 2025 10:13

karmada-bot assigned warjiang Sep 27, 2025

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2025

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2025

karmada-bot merged commit 19d3910 into karmada-io:main Sep 27, 2025
10 checks passed


		type ApiConstructor<T> = new (config: Configuration, ...args: any[]) => T;

		// Set webServer.url and use.baseURL with the location of the WebServer

Add E2E tests for Workloads/Cronjob in the dashboard #257

Add E2E tests for Workloads/Cronjob in the dashboard #257

Uh oh!

Conversation

SunsetB612 commented Sep 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SunsetB612 commented Sep 12, 2025

Uh oh!

warjiang commented Sep 22, 2025

Uh oh!

Uh oh!

warjiang Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warjiang Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

warjiang commented Sep 25, 2025

Uh oh!

warjiang Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

warjiang Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

warjiang commented Sep 27, 2025

Uh oh!

karmada-bot commented Sep 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

warjiang Sep 25, 2025 •

edited

Loading