Skip to content

chore(deps): bump react-dom and @types/react-dom in /frontend #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −21
Open

chore(deps): bump react-dom and @types/react-dom in /frontend #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea04c8b
chore(deps): bump react-dom and @types/react-dom in /frontend
dependabot[bot] May 5, 2026
851c22d
Merge branch 'main' into dependabot/npm_and_yarn/frontend/multi-2a654…
karanhudia Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@tanstack/react-query": "^5.97.0",
"@types/node": "^25.6.0",
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"@types/react-dom": "^19.2.3",

@coderabbitai coderabbitai Bot Jun 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

For react-dom@19.2.5, what is the required peer dependency range for react? For @types/react-dom@19.2.3, which @types/react major is expected?

💡 Result:

For react-dom@19.2.5, the required peer dependency range for react is ^19.2.5 [1]. For @types/react-dom@19.2.3, the expected peer dependency for @types/react is ^19.2.0 [2][3].

Citations:

🏁 Script executed:

#!/bin/bash
set -euo pipefail
nl -ba frontend/package.json | sed -n '1,80p'

Repository: karanhudia/borg-ui

Length of output: 105

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Show top portion with line numbers using cat -n (nl not available)
cat -n frontend/package.json | sed -n '1,120p'

Repository: karanhudia/borg-ui

Length of output: 4194

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find where react-dom/client is imported
rg -n "react-dom/client" frontend/src || true

# Show main.tsx for context (if it exists)
if [ -f frontend/src/main.tsx ]; then
  cat -n frontend/src/main.tsx | sed -n '1,120p'
fi

Repository: karanhudia/borg-ui

Length of output: 2027

Fix React/ReactDOM major-version mismatch in frontend/package.json.

react-dom@19.2.5 requires a react peer of ^19.2.5, and @types/react-dom@19.2.3 expects @types/react of ^19.2.0, but the repo currently keeps react and @types/react on ^18.2.0. This conflicts with the app entrypoint that uses react-dom/client + createRoot in frontend/src/main.tsx.

Update react to ^19.2.5 (or the same 19.2.x as react-dom) and @types/react to ^19.2.0 to align majors.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/package.json` at line 18, Update frontend package dependencies to
resolve the React/ReactDOM major-version mismatch: in frontend/package.json bump
"react" to ^19.2.5 (or match react-dom's 19.2.x) and bump "`@types/react`" to
^19.2.0 so they align with "react-dom" and "`@types/react-dom`" (keep
`@types/react-dom`@19.2.3 or upgrade consistently). Ensure package.json entries
for "react", "react-dom", "`@types/react`", and "`@types/react-dom`" use matching
19.2.x ranges and then run install/build (since frontend/src/main.tsx uses
react-dom/client createRoot).

"axios": "^1.16.0",
"clsx": "^2.0.0",
"cron-parser": "^5.5.0",
Expand All @@ -24,7 +24,7 @@
"lucide-react": "^1.8.0",
"qrcode": "^1.5.4",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-dom": "^19.2.5",
"react-hook-form": "^7.72.1",
"react-hot-toast": "^2.6.0",
"react-i18next": "^17.0.4",
Expand Down
Loading