chore(deps): bump react-dom and @types/react-dom in /frontend - #416
chore(deps): bump react-dom and @types/react-dom in /frontend#416dependabot[bot] wants to merge 2 commits into
Conversation
dependabot
Bot
added
the
dependencies
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
This is a major version update that may contain breaking changes. Dependency: react-dom, @types/react-dom Once reviewed and tested, manually approve and merge this PR. |
🔒 Security Scan ResultsCommit: aa04f7e
📊 See workflow artifacts for detailed reports. |
5cee222 to
359f739
Compare
|
This is a major version update that may contain breaking changes. Dependency: react-dom, @types/react-dom Once reviewed and tested, manually approve and merge this PR. |
🔒 Security Scan ResultsCommit: 2d5d4de
📊 See workflow artifacts for detailed reports. |
359f739 to
9ad7495
Compare
|
This is a major version update that may contain breaking changes. Dependency: react-dom, @types/react-dom Once reviewed and tested, manually approve and merge this PR. |
🔒 Security Scan ResultsCommit: 5f0e8c6
📊 See workflow artifacts for detailed reports. |
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.2.5 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.5/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: react-dom dependency-version: 19.2.5 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
9ad7495 to
ea04c8b
Compare
|
This is a major version update that may contain breaking changes. Dependency: @types/react-dom, react-dom Once reviewed and tested, manually approve and merge this PR. |
🔒 Security Scan ResultsCommit: 73a9c03
📊 See workflow artifacts for detailed reports. |
📝 WalkthroughWalkthroughFrontend dependencies updated: ChangesReact DOM Upgrade
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/package.json`:
- Line 18: Update frontend package dependencies to resolve the React/ReactDOM
major-version mismatch: in frontend/package.json bump "react" to ^19.2.5 (or
match react-dom's 19.2.x) and bump "`@types/react`" to ^19.2.0 so they align with
"react-dom" and "`@types/react-dom`" (keep `@types/react-dom`@19.2.3 or upgrade
consistently). Ensure package.json entries for "react", "react-dom",
"`@types/react`", and "`@types/react-dom`" use matching 19.2.x ranges and then run
install/build (since frontend/src/main.tsx uses react-dom/client createRoot).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 88856a0c-d330-4a16-ac06-76843fbfe799
⛔ Files ignored due to path filters (1)
frontend/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
frontend/package.json
| "@types/node": "^25.6.0", | ||
| "@types/react": "^18.2.0", | ||
| "@types/react-dom": "^18.2.0", | ||
| "@types/react-dom": "^19.2.3", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For react-dom@19.2.5, what is the required peer dependency range for react? For @types/react-dom@19.2.3, which @types/react major is expected?
💡 Result:
For react-dom@19.2.5, the required peer dependency range for react is ^19.2.5 [1]. For @types/react-dom@19.2.3, the expected peer dependency for @types/react is ^19.2.0 [2][3].
Citations:
- 1: react/react@v19.2.4...v19.2.5
- 2: https://registry.npmjs.org/@types/react-dom
- 3: https://www.npmjs.com/package/@types/react-dom?activeTab=dependents
🏁 Script executed:
#!/bin/bash
set -euo pipefail
nl -ba frontend/package.json | sed -n '1,80p'Repository: karanhudia/borg-ui
Length of output: 105
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show top portion with line numbers using cat -n (nl not available)
cat -n frontend/package.json | sed -n '1,120p'Repository: karanhudia/borg-ui
Length of output: 4194
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find where react-dom/client is imported
rg -n "react-dom/client" frontend/src || true
# Show main.tsx for context (if it exists)
if [ -f frontend/src/main.tsx ]; then
cat -n frontend/src/main.tsx | sed -n '1,120p'
fiRepository: karanhudia/borg-ui
Length of output: 2027
Fix React/ReactDOM major-version mismatch in frontend/package.json.
react-dom@19.2.5 requires a react peer of ^19.2.5, and @types/react-dom@19.2.3 expects @types/react of ^19.2.0, but the repo currently keeps react and @types/react on ^18.2.0. This conflicts with the app entrypoint that uses react-dom/client + createRoot in frontend/src/main.tsx.
Update react to ^19.2.5 (or the same 19.2.x as react-dom) and @types/react to ^19.2.0 to align majors.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/package.json` at line 18, Update frontend package dependencies to
resolve the React/ReactDOM major-version mismatch: in frontend/package.json bump
"react" to ^19.2.5 (or match react-dom's 19.2.x) and bump "`@types/react`" to
^19.2.0 so they align with "react-dom" and "`@types/react-dom`" (keep
`@types/react-dom`@19.2.3 or upgrade consistently). Ensure package.json entries
for "react", "react-dom", "`@types/react`", and "`@types/react-dom`" use matching
19.2.x ranges and then run install/build (since frontend/src/main.tsx uses
react-dom/client createRoot).
🔒 Security Scan ResultsCommit: 243ac1f
📊 See workflow artifacts for detailed reports. |
Coverage report
This PR does not seem to contain any modification to coverable code. |
1 participant
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.2.5Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
23f4f9f19.2.590ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.18618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)5667a41Bump next prerelease version numbers (#34639)e08f53bMatchreact-dom/statictest entrypoints and published entrypoints (#34599)Updates
@types/react-domfrom 18.3.7 to 19.2.3Commits
Summary by CodeRabbit