-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions to publish images to GH registry #307
Add github actions to publish images to GH registry #307
Conversation
Hi @ykulazhenkov. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@ykulazhenkov this is great, thank you. Would you please also update the manifests, so they reference the new image location instead of Quay? It should be enough to update https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/Makefile#L1 and |
Signed-off-by: Yury Kulazhenkov <[email protected]>
2e1d541
to
af70acc
Compare
@phoracek done |
/retest |
/test pull-e2e-ovs-cni |
@ykulazhenkov: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ykulazhenkov that seems like a legit issue with the PR. The tests are probably not able to pull the image. |
Signed-off-by: Yury Kulazhenkov <[email protected]>
af70acc
to
98a60a4
Compare
I updated the following lines with the right repo: Line 39 in 98a60a4
Line 53 in 98a60a4
I think this should fix the problem |
/retest |
Looks good, thanks a lot @ykulazhenkov |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek, ykulazhenkov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add support for multiach (linux/amd64,linux/arm64,linux/ppc64le) image build with GitHub actions and publish resulting images to Github registry.
Special notes for your reviewer:
Example of PR check: https://github.com/ykulazhenkov/ovs-cni/actions/runs/8735994526
Example of push to master: https://github.com/ykulazhenkov/ovs-cni/actions/runs/8735447193
Example of push on release: https://github.com/ykulazhenkov/ovs-cni/actions/runs/8735569774
Example of artifacts: https://github.com/ykulazhenkov/ovs-cni/pkgs/container/ovs-cni
Validate binary arch:
Release note:
Based on a great work by @zeeke in another k8snetworkplumbingwg repo.
@e0ne @SchSeba please, take a look