Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTD and E2E CI workflows #438

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Oct 3, 2023

@andrii-i andrii-i added the maintenance Maintenance/CI tasks label Oct 3, 2023
@andrii-i andrii-i marked this pull request as draft October 3, 2023 18:05
@andrii-i andrii-i marked this pull request as ready for review October 5, 2023 21:22
@dlqqq
Copy link
Collaborator

dlqqq commented Oct 11, 2023

I just rebased and squashed away the commit from the pre-commit bot. Will see if E2E tests pass after rerunning the pipeline.

edit: in hindsight this is unlikely as all the other PRs also have failing CI.

@dlqqq
Copy link
Collaborator

dlqqq commented Oct 11, 2023

Ah, this looks like an upstream change in Playwright that somehow slipped by, even when fixing jupyterlab==4.0.3 in our tests. See here: jupyterlab/jupyterlab#15116

@JasonWeill
Copy link
Collaborator

Not just our repo is affected; I had to upgrade readthedocs config in jupyter/jupyter#698 as well

@dlqqq dlqqq changed the title Add readthedocs configuration file v2 Fix RTD and E2E CI workflows Oct 11, 2023
@dlqqq
Copy link
Collaborator

dlqqq commented Oct 12, 2023

Resolved this issue. Here was my thought process (this may be helpful to @andrii-i):

The PR that backports a fix for this issue to 4.0.x is jupyterlab/jupyterlab#15118. Looking at the PR, we see it was merged in as commit f73ea9acc67a5dd581e64b400018d3373d3676dc. Then, I ran:

git tag --contains f73ea9acc67a5dd581e64b400018d3373d3676dc

to see that it was first included in the v4.0.6 release. This indicated to me that upgrading to v4.0.6 in our tests would be solve this CI failure. After making sure to also set this patch version for Galata and updating ui-tests/yarn.lock, I was able to get CI passing again.

@dlqqq dlqqq merged commit 9e0227e into jupyter-server:main Oct 12, 2023
@andrii-i
Copy link
Collaborator Author

Thank you @dlqqq

@andrii-i andrii-i deleted the fix-readthedocs branch January 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance/CI tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants