-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RTD and E2E CI workflows #438
Conversation
andrii-i
commented
Oct 3, 2023
- Fixes ReadTheDocs build process (error example: https://readthedocs.org/projects/jupyter-scheduler/builds/22111095/) by adding readthedocs configuration file v2
e1e2c5c
to
43845a1
Compare
I just rebased and squashed away the commit from the pre-commit bot. Will see if E2E tests pass after rerunning the pipeline. edit: in hindsight this is unlikely as all the other PRs also have failing CI. |
Ah, this looks like an upstream change in Playwright that somehow slipped by, even when fixing |
Not just our repo is affected; I had to upgrade readthedocs config in jupyter/jupyter#698 as well |
7602976
to
1100c8e
Compare
1100c8e
to
094ce44
Compare
Resolved this issue. Here was my thought process (this may be helpful to @andrii-i): The PR that backports a fix for this issue to 4.0.x is jupyterlab/jupyterlab#15118. Looking at the PR, we see it was merged in as commit
to see that it was first included in the v4.0.6 release. This indicated to me that upgrading to v4.0.6 in our tests would be solve this CI failure. After making sure to also set this patch version for Galata and updating |
Thank you @dlqqq |