Skip to content

Commit

Permalink
Fix RTD and E2E CI workflows (#438)
Browse files Browse the repository at this point in the history
* Add readthedocs configuration file v2

* fix jupyterlab==4.0.6 in E2E tests

* fix @jupyterlab/galata to 5.0.6

---------

Co-authored-by: David L. Qiu <[email protected]>
  • Loading branch information
andrii-i and dlqqq authored Oct 12, 2023
1 parent 587ab51 commit 9e0227e
Show file tree
Hide file tree
Showing 4 changed files with 638 additions and 577 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ jobs:
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

# when updating this version, make sure to update ui-tests/package.json
# and the lockfile accordingly.
- name: Install extension dependencies
run: python -m pip install -U jupyterlab==4.0.3
run: python -m pip install -U jupyterlab==4.0.6

- name: Build the extension
run: |
Expand Down Expand Up @@ -57,7 +59,7 @@ jobs:
working-directory: ui-tests
run: jlpm install-chromium

- name: Execute integration tests
- name: Run E2E Playwright tests
working-directory: ui-tests
run: jlpm test

Expand Down
17 changes: 17 additions & 0 deletions .readthedocs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
version: 2

build:
os: ubuntu-22.04
tools:
python: "3.11"
nodejs: "18"

sphinx:
configuration: docs/conf.py

python:
install:
- method: pip
path: .
extra_requirements:
- docs
4 changes: 2 additions & 2 deletions ui-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"test:update": "jlpm playwright test --update-snapshots"
},
"devDependencies": {
"@jupyterlab/galata": "^5.0.0",
"@playwright/test": "^1.32.0"
"@jupyterlab/galata": "5.0.6",
"@playwright/test": "^1.32.2"
}
}
Loading

0 comments on commit 9e0227e

Please sign in to comment.