-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Replace <img> tags with Next.js Image Component #824 #997
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR!! Nice job. I just left small comments.
@benjagm all requested changes are implemented, kindly check it |
@benjagm kindly check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@29deepanshutyagi left some suggestions to be added in the PR
@29deepanshutyagi there are still some comments left to be resolved, can you pls. have a look on them |
yeah will commit those changes soon |
kindly review it @benjagm @DarhkVoyd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@29deepanshutyagi Great progress!! just small fixes and we are good to go 🚀 |
,> @29deepanshutyagi Great progress!! just small fixes and we are good to go 🚀 but i had already set the width and height according to their corresponding tailwind class value there previously |
Hi @29deepanshutyagi any progress on this? We're almost there just few changes left |
|
Hi @29deepanshutyagi , I cloned your repo to have a look what the conflicts are how to fix them. You can follow below steps to resolve these conflicts.
Similarly you can do Accept Both option for After this you can stage all these merge changes(look for + icon in source control) and you can commit all the changes and push those changes like you usually do. |
82030a9
to
8676fc2
Compare
This PR refactors several img tags throughout the project to utilize the Image component provided by Next.js.Replaced img tags with Image components
changes are pushed through check branch
issue #824 , kindly check it