Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Replace <img> tags with Next.js Image Component #824 #997

Closed
wants to merge 0 commits into from

Conversation

29deepanshutyagi
Copy link
Contributor

@29deepanshutyagi 29deepanshutyagi commented Oct 3, 2024

This PR refactors several img tags throughout the project to utilize the Image component provided by Next.js.Replaced img tags with Image components

changes are pushed through check branch

issue #824 , kindly check it

@29deepanshutyagi 29deepanshutyagi requested a review from a team as a code owner October 3, 2024 13:55
Copy link

github-actions bot commented Oct 3, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 82030a9

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9899bc7) to head (82030a9).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #997   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR!! Nice job. I just left small comments.

@29deepanshutyagi
Copy link
Contributor Author

29deepanshutyagi commented Oct 4, 2024

@benjagm all requested changes are implemented, kindly check it

@29deepanshutyagi
Copy link
Contributor Author

@benjagm kindly check it

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@29deepanshutyagi left some suggestions to be added in the PR

@DhairyaMajmudar
Copy link
Member

@29deepanshutyagi there are still some comments left to be resolved, can you pls. have a look on them

@29deepanshutyagi
Copy link
Contributor Author

29deepanshutyagi commented Oct 23, 2024

@29deepanshutyagi there are still some comments left to be resolved, can you pls. have a look on them

yeah will commit those changes soon

@29deepanshutyagi
Copy link
Contributor Author

29deepanshutyagi commented Oct 30, 2024

kindly review it @benjagm @DarhkVoyd

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Images of case studies page is not as it was before

image

  1. Sidebar Icons size is less as compare to before

image

  1. Tooling page icons size is decreased as compared to before

image

@DhairyaMajmudar
Copy link
Member

@29deepanshutyagi Great progress!! just small fixes and we are good to go 🚀

@29deepanshutyagi
Copy link
Contributor Author

29deepanshutyagi commented Nov 15, 2024

,> @29deepanshutyagi Great progress!! just small fixes and we are good to go 🚀

but i had already set the width and height according to their corresponding tailwind class value there previously

@DhairyaMajmudar
Copy link
Member

Hi @29deepanshutyagi any progress on this? We're almost there just few changes left

@29deepanshutyagi
Copy link
Contributor Author

Hi @29deepanshutyagi any progress on this? We're almost there just few changes left

@heysujal
Copy link
Contributor

Hi @29deepanshutyagi , I cloned your repo to have a look what the conflicts are how to fix them.

You can follow below steps to resolve these conflicts.

  1. Checkout to your check branch.
  2. Run git remote add upstream https://github.com/json-schema-org/website.git
  3. Run git pull upstream main
  4. Use the souce control in VSCode
  5. Accept Current change for Card.tsx
    image

Similarly you can do Accept Both option for ToolingDetailModal.tsx
image

After this you can stage all these merge changes(look for + icon in source control) and you can commit all the changes and push those changes like you usually do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants