Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Add missing alt attribute to images #1041

Closed
heysujal opened this issue Oct 19, 2024 · 6 comments
Closed

🐛 Bug: Add missing alt attribute to images #1041

heysujal opened this issue Oct 19, 2024 · 6 comments
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: On Hold Similar to blocked, but is assigned to someone.

Comments

@heysujal
Copy link
Contributor

heysujal commented Oct 19, 2024 •
edited
Loading

Describe the bug

Upon generating Lighthouse report for homepage of JSON Schema, a number of issues can be found. One of them being that many images are missing the required alt attribute.
The list of images is long and all of them could not come in the screenshots.

A similar error : Links must have discernible text can be fixed for <a> tags too by adding aria-label attribute to them. Read more here.

Steps To Reproduce

  1. Go to https://json-schema.org/
  2. Open Developer tools and generate lighthouse report.

Expected Behavior

All images should have a alt attribute to improve accessibility.

Screenshots

Screenshot 2024-10-19 at 4 46 10 PM Screenshot 2024-10-19 at 4 49 01 PM

Device Information [optional]

- OS: MacOS
- Browser: Chrome
- version: 129.0.6668.101

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@heysujal heysujal added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Oct 19, 2024
@Utkarsh-Agarwal-585
Copy link

@heysujal Could you please assign it to me?

@heysujal
Copy link
Contributor Author

@DhairyaMajmudar @benjagm can do it.

@DhairyaMajmudar
Copy link
Member

Thank you @heysujal for reporting the issue
@Utkarsh-Agarwal-585 let's wait for the merger of PR #997 since it consists of changes related to the image tag.

@DhairyaMajmudar DhairyaMajmudar added Status: On Hold Similar to blocked, but is assigned to someone. and removed Status: Triage This is the initial status for an issue that requires triage. labels Oct 19, 2024
@chenul29
Copy link

Hi everyone.
Is this issue still available? Can I work for this?

CharitSinghChauhan added a commit to CharitSinghChauhan/website that referenced this issue Dec 26, 2024
@CharitSinghChauhan
Issue json-schema-org#1041 Add missing alt attribute to images
9410f29
@CharitSinghChauhan CharitSinghChauhan mentioned this issue Dec 26, 2024
Closed
CharitSinghChauhan added a commit to CharitSinghChauhan/website that referenced this issue Dec 26, 2024
@CharitSinghChauhan
Improve the code Quality json-schema-org#1041
29db0d6
CharitSinghChauhan added a commit to CharitSinghChauhan/website that referenced this issue Dec 26, 2024
@CharitSinghChauhan
Issue json-schema-org#1041 Add Add missing alt attribute to images im…
376b996 
…prove the code quality
@29deepanshutyagi 29deepanshutyagi mentioned this issue Jan 1, 2025
Merged
@Thund3rHawk
Copy link
Contributor

Hello @heysujal @DhairyaMajmudar, Could you please assign me to work on the issue?

@DhairyaMajmudar
Copy link
Member

Closing as duplicate of #824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: On Hold Similar to blocked, but is assigned to someone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1041 Add missing alt attribute to images CharitSinghChauhan/website
5 participants
@heysujal @Utkarsh-Agarwal-585 @Thund3rHawk @DhairyaMajmudar @chenul29