Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify the new-implementation.yml to trigger workflow on first PR #973

Merged

Conversation

nikhilkalburgi
Copy link
Contributor

What kind of change does this PR introduce?

bugfix

Issue Number:

Closes #755
Screenshots/videos:

If relevant, did you update the documentation?

No

Summary
This adds an additional condition to the existing check to trigger the action for first time contributors only for th path "data/tooling-data.yml"

Does this PR introduce a breaking change?

No

@nikhilkalburgi nikhilkalburgi requested a review from a team as a code owner September 23, 2024 12:32
Copy link

github-actions bot commented Sep 23, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview d5ee854

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (014026c) to head (d5ee854).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #973   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a high level review and looks good. Let's merge it.

Thanks a lot for your contribution!!

@benjagm benjagm merged commit 80b55f3 into json-schema-org:main Oct 2, 2024
10 of 11 checks passed
Copy link

github-actions bot commented Oct 2, 2024

Congratulations, @nikhilkalburgi for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

@DhairyaMajmudar DhairyaMajmudar added the Hacktoberfest Issues accepeted Hacktoberfest'24 label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues accepeted Hacktoberfest'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Modify new-implementation.yml workflow to run only for first time contributors
3 participants