-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify the new-implementation.yml to trigger workflow on first PR #938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nikhilkalburgi for the PR can you pls. remove the yarn.lock file from the PR. This will fix the failing CI
Why does this have so many changes?! Isn't this just a workflow edit? |
The large diff is because of the changes done in yarn.lock file |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
Hi @DhairyaMajmudar @gregsdennis , I have updated this PR. Removed the changes that occured in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Hi @nikhilkalburgi Why you closed this PR? |
What kind of change does this PR introduce?
bugfix
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
No
Summary
This adds an additional condition to the existing check to trigger the action for first time contributors only for th path "data/tooling-data.yml"
Does this PR introduce a breaking change?
No