Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the new-implementation.yml to trigger workflow on first PR #938

Closed
wants to merge 4 commits into from
Closed

Conversation

nikhilkalburgi
Copy link
Contributor

What kind of change does this PR introduce?

bugfix

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

No

Summary
This adds an additional condition to the existing check to trigger the action for first time contributors only for th path "data/tooling-data.yml"

Does this PR introduce a breaking change?

No

@nikhilkalburgi nikhilkalburgi requested a review from a team as a code owner September 11, 2024 10:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nikhilkalburgi for the PR can you pls. remove the yarn.lock file from the PR. This will fix the failing CI

@gregsdennis
Copy link
Member

Why does this have so many changes?! Isn't this just a workflow edit?

@DhairyaMajmudar
Copy link
Member

Why does this have so many changes?! Isn't this just a workflow edit?

The large diff is because of the changes done in yarn.lock file

Copy link

github-actions bot commented Sep 11, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 443551f

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b8fa129) to head (dd91683).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #938   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikhilkalburgi
Copy link
Contributor Author

Hi @DhairyaMajmudar @gregsdennis ,

I have updated this PR. Removed the changes that occured in yarn.lock file. Let me know, if the changes works for you.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@benjagm
Copy link
Collaborator

benjagm commented Sep 23, 2024

Hi @nikhilkalburgi Why you closed this PR?

@nikhilkalburgi
Copy link
Contributor Author

nikhilkalburgi commented Sep 23, 2024

Hi @benjagm ,

There was a small conflict in my forked repo, so re-forked the repo. I have created another PR #973 . Please refer to this new PR for implemented changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Modify new-implementation.yml workflow to run only for first time contributors
4 participants