Link-redirect-fix #1187
Link-redirect-fix #1187
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 384 +11
Branches 94 99 +5
=========================================
+ Hits 373 384 +11 ☔ View full report in Codecov by Sentry. |
|
@DhairyaMajmudar Fixed the linting issue |
|
@DhairyaMajmudar Can u review this pr? |
|
@DhairyaMajmudar Resolved the merge conflict |
| @@ -29,7 +29,7 @@ export default function Content({ | |||
| content: any; | |||
| }) { | |||
| const newTitle = 'Code of Conduct'; | |||
|
|
|||
| const fileRenderType = 'tsx'; | |||
There was a problem hiding this comment.
We should probably redirect to the code of conduct instead of this tsx.
There was a problem hiding this comment.
@DarhkVoyd Do I need to redirect to the code of conduct submodule github page?
There was a problem hiding this comment.
@DarhkVoyd Resolved this issue
There was a problem hiding this comment.
Hard coding these values inside fileRenderType doesn't seem like a good idea, instead let's allow this component to accept urls as strings for these cases where we can simply pass custom links.
So, instead of code_of_conduct we should instead be passing something like: https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md
| @@ -21,7 +21,7 @@ export async function getStaticProps() { | |||
|
|
|||
| export default function ContentExample({ blocks }: { blocks: any[] }) { | |||
| const newTitle = 'Sponsors'; | |||
|
|
|||
| const fileRenderType = '_indexmd'; | |||
There was a problem hiding this comment.
In case of Code of Conduct submodule, the changes point to tsx but here for sponsors submodule we are pointing to the _indexmd, this behavior is not consistent.
There was a problem hiding this comment.
@DarhkVoyd Resolved the issue
There was a problem hiding this comment.
Hard coding these values inside fileRenderType doesn't seem like a good idea, instead let's allow this component to accept urls as strings for these cases where we can simply pass custom links.
So, instead of sponsors we should instead be passing something like: https://github.com/json-schema-org/community/blob/main/programs/sponsors/sponsors.md
There was a problem hiding this comment.
@DarhkVoyd Got it I'll work on it and make the changes asap.
|
@DarhkVoyd Done with the changes , Review the pr. |
What kind of change does this PR introduce?
Change to correct wrong redirecting URLs
Issue Number:
closes: #1038
Screenshots/videos:
If relevant, did you update the documentation?
Summary
This pull request addresses an issue related to incorrect URL redirection in the JSON Schema website. Users were being redirected to incorrect or unintended pages when clicking on certain links.
Changes Made:
Corrected Redirecting URLs: Updated the wrong redirecting URLs in various components to ensure they point to the correct destinations. This change enhances navigation and provides users with access to the intended content.
Refactored JSX Components: Adjusted the formatting of JSX components to comply with the project's style guide. Specifically, I ensured that there were proper spaces before closing brackets in the JSX tags, addressing the errors raised by the reviewers.
Code Consistency: Ensured consistency in the codebase by adhering to Prettier and ESLint rules, which included correcting formatting issues to enhance code readability and maintainability.
These changes improve user experience by ensuring that links function correctly, reducing frustration caused by misdirected navigation.
Does this PR introduce a breaking change?
No