Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mis-linked pages #1165

Closed
wants to merge 2 commits into from
Closed

Conversation

IyaadArshad
Copy link
Contributor

What kind of change does this PR introduce?
This PR fixes the various 404 issues users encounter when trying to contribute on some pages (Bugfixes)

Issue Number:

Screenshots/videos:
image

Summary
Fixes the broken contribution buttons

@IyaadArshad IyaadArshad requested a review from a team as a code owner December 16, 2024 06:35
@IyaadArshad
Copy link
Contributor Author

Full PR not finished yet

@IyaadArshad
Copy link
Contributor Author

IyaadArshad commented Dec 16, 2024

I've looked at all the pages which contain this variable with the assigned value before:

const markdownFile = '_indexPage';

Some of the links correctly return the source code, others return page not found.

Here are the links which use the markdownFile as _indexPage


https://json-schema.org/learn 🟢

Contribution: https://github.com/json-schema-org/website/blob/main/pages/learn/_index.md (Incorrect)

Correct page: https://github.com/json-schema-org/website/blob/main/pages/learn/index.page.tsx


https://json-schema.org/overview/case-studies

Contribution: https://github.com/json-schema-org/website/blob/main/pages/overview/case-studies/_index.md (Incorrect)

Correct page: https://github.com/json-schema-org/website/blob/main/pages/overview/case-studies/index.page.tsx


https://json-schema.org/specification/migration

Contribution: https://github.com/json-schema-org/website/blob/main/pages/specification/migration/_index.md (Correct)


https://json-schema.org/understanding-json-schema

Contribution: https://github.com/json-schema-org/website/blob/main/pages/understanding-json-schema/_index.md (Correct)


https://json-schema.org/overview/use-cases

Contribution: https://github.com/json-schema-org/website/blob/main/pages/overview/use-cases/_index.md (Incorrect)

Correct page: https://github.com/json-schema-org/website/blob/main/pages/overview/use-cases/index.page.tsx


https://json-schema.org/specification/release-notes

Contribution: https://github.com/json-schema-org/website/blob/main/pages/specification/release-notes/_index.md (Correct)


https://json-schema.org/specification/json-hyper-schema

Contribution: https://github.com/json-schema-org/website/blob/main/pages/specification/json-hyper-schema/_index.md (Correct)


https://json-schema.org/understanding-json-schema/reference

Contribution: https://github.com/json-schema-org/website/blob/main/pages/understanding-json-schema/reference/_index.md (Correct)


@Relequestual
Copy link
Member

Looks like you need to run linting and fix the lint errors to pass the PR checks =]
Then it should build and deploy a preview of the site with the PR.

@benjagm benjagm requested a review from DarhkVoyd December 20, 2024 16:07
@benjagm
Copy link
Collaborator

benjagm commented Dec 27, 2024

Hi, @IyaadArshad, The referenced issue is already assigned to another contributor, and they are actively working on it. For that reason we are going to close this one in favour of #1187 . Next time please wait to get assigned to an issue before start working on it.

@benjagm benjagm closed this Dec 27, 2024
@IyaadArshad IyaadArshad deleted the patch-6 branch December 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Mis-linked page (Again)
3 participants