fix: address PR #34 code review feedback

[jrepp]

Summary

Follow-up to PR #34 addressing Copilot code review feedback that came after the merge.

Changes

1. Remove unused doc_type parameter from ensure_required_fields() in whitespace.py

   • Simplified function signature by removing unused parameter
   • Updated all 9 call sites in whitespace.py and test files
   • Removed doc_type detection logic since it wasn't being used

2. Remove hardcoded test count badge from README.md

   • Removed "628 tests passing" badge that required manual updates
   • Badge was error-prone and would become stale
   • Coverage badge and CI badge already show test health

3. Re: Python 3.9/3.10 datetime compatibility (timestamps.py)

   • Addressed nitpick about inline .replace('Z', '+00:00') workaround
   • Current implementation is intentional for simplicity
   • Helper function would add overhead for single-line workaround
   • Inline comment clearly explains the reasoning

Test Status

✅ All 628 tests passing, 1 skipped
✅ Ruff lint checks passing
✅ Ruff format checks passing

Related

• Addresses review comments from PR feat: comprehensively enhance all document templates #34
• Original review: feat: comprehensively enhance all document templates #34 (comment)

🤖 Generated with Claude Code

[Copilot]

Pull Request Overview

This PR addresses code review feedback from PR #34 by removing unused parameters and outdated documentation elements. The changes simplify the codebase by eliminating unnecessary complexity while maintaining all existing functionality.

Key changes:

• Removed unused doc_type parameter from ensure_required_fields() function and updated all call sites
• Removed hardcoded test count badge from README that required manual maintenance
• Acknowledged datetime compatibility implementation as intentional (no code changes needed)

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File	Description
docuchango/fixes/whitespace.py	Removed unused doc_type parameter from ensure_required_fields() and eliminated doc type detection logic
tests/test_whitespace_fixes.py	Updated 5 function calls to remove doc_type argument
tests/test_whitespace_comprehensive.py	Updated 7 function calls and renamed test method to reflect removal of doc type handling
README.md	Removed hardcoded test count badge and associated maintenance comment

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.66%. Comparing base (5fa12eb) to head (3ac25b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   61.59%   61.66%   +0.07%     
==========================================
  Files          23       23              
  Lines        2924     2914      -10     
  Branches      544      540       -4     
==========================================
- Hits         1801     1797       -4     
+ Misses       1060     1057       -3     
+ Partials       63       60       -3     

Flag	Coverage Δ
unittests	61.66% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
docuchango/fixes/whitespace.py	95.45% <100.00%> (+5.65%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f41d6...3ac25b5. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.