All: Fix the copy to clipboard button #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Clipboard.js library often doesn't really copy to clipboard despite reporting it completed successfully. Instead, this commit switches from it to a polyfill to a native clipboard async API that works (tested in Chrome 81, Firefox 75 & Safari 13.1). Fixes jquery/codeorigin.jquery.com#49
timmywil
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Clipboard.js library often doesn't really copy to clipboard despite
reporting it completed successfully. Instead, this PR switches from it
to a polyfill to a native clipboard async API that works (tested in Chrome 81,
Firefox 75 & Safari 13.1).
Fixes jquery/codeorigin.jquery.com#49