Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy to clipboard button don't work #49

Closed
ubaidisaev opened this issue Apr 28, 2019 · 4 comments · Fixed by jquery/jquery-wp-content#422
Closed

Copy to clipboard button don't work #49

ubaidisaev opened this issue Apr 28, 2019 · 4 comments · Fixed by jquery/jquery-wp-content#422

Comments

@ubaidisaev
Copy link

code jquery com

Returns just url of current page ( code.jquery.com ).

OS: Window 10
Browser: Chrome 73

@dmethvin
Copy link
Member

This definitely seems broken. For some reason the Algolia search code is on this page and it's throwing an error, that might be related.

@paulsmithkc
Copy link

I can confirm that this is broken. It is not working for me or any of my students.

@s-pace
Copy link

s-pace commented Apr 15, 2020

I do not think the DocSearch script is related to this issue but I will make sure the snippet is only integrated if the input is here.

mgol added a commit to mgol/jquery-wp-content that referenced this issue Apr 15, 2020
The Clipboard.js library often doesn't really copy to clipboard despite
reporting it completed successfully. Instead, this commit switches from it
to a polyfill to a native clipboard async API that works (tested in Chrome 81,
Firefox 75 & Safari 13.1).

Fixes jquery/codeorigin.jquery.com#49
@mgol
Copy link
Member

mgol commented Apr 15, 2020

There's a problem with the Clipboard.js library, I replaced it with something that works. PR: jquery/jquery-wp-content#422.

mgol added a commit to jquery/jquery-wp-content that referenced this issue Apr 16, 2020
The Clipboard.js library often doesn't really copy to clipboard despite
reporting it completed successfully. Instead, this commit switches from it
to a polyfill to a native clipboard async API that works (tested in Chrome 81,
Firefox 75 & Safari 13.1).

Fixes jquery/codeorigin.jquery.com#49
Closes #422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

5 participants