Fix release build#193
Merged
Merged
Conversation
PR #179 broke release builds by making it necessary for `LiveAskQuestion` and `SEED` to both now be available regardless of whether `debug_assertions` is set. That's unfortunate, since `SEED` in particular would make the binary quite large. So I've instead made it so that in release mode (or rather, without `debug_assertions`), `SEED` is _not_ compiled in, and DynamoDB mode is _always_ used. I've also added a CI job to check `--release --target aarch64-unknown-linux-gnu` so that this can't happen in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #179 broke release builds by making it necessary for
LiveAskQuestionandSEEDto both now be available regardless of whetherdebug_assertionsis set. That's unfortunate, sinceSEEDin particular would make the binary quite large. So I've instead made it so that in release mode (or rather, withoutdebug_assertions),SEEDis not compiled in, and DynamoDB mode is always used.I've also added a CI job to check
--release --target aarch64-unknown-linux-gnuso that this can't happen in the future.