Skip to content

chapter 03 - destructors #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lauti7 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chapter 03 - destructors #35

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43bfc94
errata
lauti7 Apr 1, 2023
61237e4
edit
lauti7 Apr 1, 2023
7622b2b
Update _errata/print01-ch03-destructors.md
lauti7 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions _errata/print01-ch03-destructors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
chapter: 3
page: 47
kind: wording
reporter: lauti7
date: 2023-03-31
---
You says:
"The second workaround is to make each of your fields takeable. You can "take" an Option by replacing it with None (which is what Option:: take does), but you can do this with many other types as well. For example, you can Take a vecOr HashMap by simply replacing them with their cheap-to-construct default values--std::mem::take is your friend here. This approach works great if your types have sane "empty" values but gets tedious if you must wrap nearly every field in an Option and then modify every access of those fields with a matching unwrap."

I think that in the last sentence "This approach..." you start referring to the `std::mem::take` because you talk about "empty" values, and what `std::mem::take` does is to replace the value with the `Default` implementation and then you end talking about `Option` saying "but gets tedious ...". I think the last sentence is not pretty clear this way.