fix: don't treat 429 as success in sendToRelay#3413
Open
SirBrenton wants to merge 1 commit into
Open
Conversation
A 429 from the relay means the report was rate-limited and not accepted. Returning true silently dropped crash reports under sustained rate limiting, giving callers false confidence that reporting succeeded. Return false on 429 so callers can decide whether to retry. Honors the never-throws contract — no blocking retry logic added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sendToRelayinlib/reporter.jswas returningtruewhen the relay responded with 429, treating a rate-limited request as accepted.Why this matters
A 429 means the relay did not accept the report. Returning
truesilently dropped crash reports under sustained rate limiting — giving callers false confidence that reporting succeeded when data was lost.Fix shape
Return
falseon 429. Preserves the never-throws contract. No blocking retry logic added. Callers decide whether to retry.