Fix: DeleteCommand returns 0 for SuccessCount and FailCount when errors occur

[bhanurp]

• All tests passed. If this feature is not already covered by the tests, I added new tests.
• All static analysis checks passed.
• Appropriate label is added to auto generate release notes.
• I used gofmt for formatting the code before submitting the pull request.
• PR description is clear and concise, and it includes the proposed solution/fix.

---

Description

This PR fixes a bug where DeleteCommand.Result().SuccessCount() and Result().FailCount() return 0 when 404 errors (or other errors) occur during deletion, even though some files may have been successfully deleted.

When using DeleteCommand and encountering errors (e.g., 404 errors when items are already deleted by another process), both SuccessCount() and FailCount() returned 0

solution

Changed to capture the deletion error separately and return actual counts regardless of whether an error occurred.

[itsmeleela]

@bhanurp I didn't understand the need of renaming err to deleteErr and then assigning deleteErr to err?

[bhanurp]

to avoid variable shadowing of err at delete.go#L42
even below should work as well

var successCount, failedCount int successCount, failedCount, err = dc.DeleteFiles(reader) // Uses existing 'err' result := dc.Result() result.SetSuccessCount(successCount) result.SetFailCount(failedCount)

moving successCount, failedCount as variable declaration instead of shorthand :=

[github-actions]

---

🐸 JFrog Frogbot