Added e2e for DeleteCommand returns 0 for SuccessCount and FailCount … #3307
+292
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when errors occur
bhanurp
added
bug
bhanurp
added
safe to test
…when errors occur
bhanurp
added
safe to test
…when errors occur
bhanurp
added
safe to test
bhanurp
added
safe to test
bhanurp
added
safe to test
bhanurp
added
safe to test
bhanurp
added
safe to test
bhanurp
added
safe to test
bhanurp
commented
Jan 12, 2026
go.mod
Outdated
|
|
||
| // replace github.com/jfrog/jfrog-cli-artifactory => github.com/fluxxBot/jfrog-cli-artifactory v0.0.0-20260105073552-ae4f86048a11 | ||
| // | ||
| replace github.com/jfrog/jfrog-cli-artifactory => github.com/bhanurp/jfrog-cli-artifactory v0.1.12-0.20260108075108-b5389ca4d380 |
Contributor
Author
There was a problem hiding this comment.
placeholder to remove replace
bhanurp
removed
the
safe to test
bhanurp
added
the
safe to test
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when errors occur
masterbranch.go vet ./....go fmt ./....Description
This PR fixes a bug where DeleteCommand.Result().SuccessCount() and Result().FailCount() return 0 when 404 errors (or other errors) occur during deletion, even though some files may have been successfully deleted.
When using DeleteCommand and encountering errors (e.g., 404 errors when items are already deleted by another process), both SuccessCount() and FailCount() returned 0
solution
Changed to capture the deletion error separately and return actual counts regardless of whether an error occurred.
Depends On
jfrog/jfrog-cli-artifactory#342