Skip to content

Fix getLogInputStream and doConsoleText for large log files #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
svanoort merged 5 commits into from
Nov 6, 2018
Merged

Fix getLogInputStream and doConsoleText for large log files #114

svanoort merged 5 commits into from
Nov 6, 2018

Conversation

@dwnusbaum
Copy link
Member

@dwnusbaum dwnusbaum commented Nov 5, 2018

Subsumes #113. CC @kshultzCB

I will add a test specifically for getLogInputStream.

@dwnusbaum dwnusbaum requested review from jglick and svanoort November 5, 2018 21:18
@svanoort
Copy link
Member

svanoort commented Nov 5, 2018

Looks OK pending test for getLogInputStream

@dwnusbaum
Copy link
Member Author

dwnusbaum commented Nov 5, 2018 •
edited
Loading

Test is up now. I'm happy to consolidate the fix/test if desired to avoid duplication.

@dwnusbaum
Copy link
Member Author

dwnusbaum commented Nov 6, 2018

Just noticed that getLog has the same problem. I am not sure how often that method is called since it's deprecated, but I will go ahead and fix it as well.

@svanoort svanoort merged commit 72cc8ac into jenkinsci:master Nov 6, 2018
@dwnusbaum dwnusbaum deleted the log-tweaks branch November 6, 2018 17:14
@dwnusbaum dwnusbaum mentioned this pull request Nov 9, 2018
Merged
@jglick jglick mentioned this pull request Apr 2, 2019
Closed
4 tasks
@dwnusbaum dwnusbaum mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick jglick approved these changes

@svanoort svanoort svanoort approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwnusbaum @svanoort @jglick