Fix build errors by updating minimum core version, parent POM, and dependencies #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
approved these changes
May 5, 2020
olamy
approved these changes
May 6, 2020
car-roll
approved these changes
May 6, 2020
kshultzCB
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix enforcer errors seen in the CI builds when testing against 2.222.x.
2.176.x is the fourth-oldest LTS line at this point, so it seems safe to update. I also pulled in the plugin BOM to manage plugin dependency versions.
I also had to fix some SpotBugs issues as part of the update. One was for deprecated and unused code that I just suppressed, but I think the other found a real (but very minor) bug where if you had a single Pipeline step that produced more than 10k lines of log output, only the first 10k lines would be shown if you viewed the logs for that step in the the "Pipeline Steps" view. It is analogous to jenkinsci/workflow-job-plugin#114, but that was for the log for the whole build, so it was much more important.