Previous doConsoleText override failed to work past LargeText.MAX_LINES_READ #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
approved these changes
Nov 5, 2018
Member
dwnusbaum
left a comment
dwnusbaum
left a comment
There was a problem hiding this comment.
Looks good to me assuming @kshultzCB confirms it fixes the issue he was seeing.
Member
Author
|
more CI problems |
svanoort
previously requested changes
Nov 5, 2018
Member
svanoort
left a comment
svanoort
left a comment
There was a problem hiding this comment.
This needs some form of unit test
svanoort
reviewed
Nov 5, 2018
| // Similar to writeWholeLogTo but terminates even if !logText.complete: | ||
| long pos = 0; | ||
| while (true) { | ||
| long pos2 = getLogText().writeLogTo(pos, os); |
Member
There was a problem hiding this comment.
Interesting possibility: what if the log is being generated faster than it can be written to output?
Member
Author
There was a problem hiding this comment.
Then I guess you are going to be swamped with output. Not much we can do about that.
svanoort
approved these changes
Nov 5, 2018
Member
|
|
jglick
added a commit
to jglick/jenkins
that referenced
this pull request
Nov 8, 2018
…enkinsci/workflow-job-plugin#113 I cannot seem to remember to do it.
jglick
added a commit
to jglick/jenkins
that referenced
this pull request
Apr 2, 2019
…enkinsci/workflow-job-plugin#113 I cannot seem to remember to do it. (cherry picked from commit b2ce2bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to #112 discovered by @kshultzCB.