Optimized version of doConsoleText to avoid a memory buffer #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
hmm, CI issues |
dwnusbaum
approved these changes
Nov 5, 2018
Member
dwnusbaum
left a comment
dwnusbaum
left a comment
There was a problem hiding this comment.
Looks good to me assuming tests pass, since the default implementation went through getLogInputStream which buffers the whole log in memory and this implementation will no longer do that.
svanoort
approved these changes
Nov 5, 2018
|
I think this limitation is still not fixed. Parallel builds in the pipeline are still running into this issue. |
Member
Author
|
#164? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed by @kshultzCB.