Replacing Guava’s CacheBuilder with Java Platform equivalents
#220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
May 7, 2021
| public Function load(Class from) { | ||
| PARSE_METHODS = new ClassValue<Function>() { | ||
| @Override | ||
| public Function computeValue(Class<?> from) { |
Member
Author
There was a problem hiding this comment.
Not only simpler, but should fix a memory leak in the rare case that fromStapler is actually defined: #213 (comment)
…t grok `CacheBuilder`
Member
Author
|
Lightly tested: ran Jenkins with this version of Stapler, did various GUI stuff, watched java -jar …/jenkins-cli.jar -s http://localhost:8080/jenkins/ tail-log -l FINE org.kohsuke.stapler.AbstractTearOff |
basil
approved these changes
May 7, 2021
10 tasks
Member
|
Testing the incremental in jenkinsci/jenkins#5422. If it passes and this PR is merged and released, I'll mark that PR as ready to review so we can pick up this change from core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #213 (comment), this completely removed the Guava dependency without adding anything in its place. Does not really make the code noticeably more complex. Continues #215. @basil @jtnord