-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[JENKINS-65442] - Improve performance when encoding unicode characters in JSON API + Remove Stapler's Guava dependency #5422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Jesse Glick <[email protected]>
oleg-nenashev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process
|
We will need changelog, because it includes multiple other changes |
|
@basil please review the suggested changelog. It would be also great if you could keep the pull request template in your pull requests. We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process |
|
Sorry! I normally do that, but I had repurposed this PR for something other than its original purpose and had forgotten to update the description. I just updated it now to conform to the template. |
See JENKINS-65442. This PR updates Stapler to the latest version, which includes the fix for JENKINS-65442 and jenkinsci/stapler#220 (which removes Stapler's dependency on Guava).
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).