Skip to content

Conversation

@basil
Copy link
Member

@basil basil commented Apr 15, 2021

See JENKINS-65442. This PR updates Stapler to the latest version, which includes the fix for JENKINS-65442 and jenkinsci/stapler#220 (which removes Stapler's dependency on Guava).

Proposed changelog entries

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the dependencies Pull requests that update a dependency file label Apr 16, 2021
@basil basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label May 7, 2021
Co-authored-by: Jesse Glick <[email protected]>
@jglick jglick marked this pull request as ready for review May 8, 2021 15:29
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label May 8, 2021
@oleg-nenashev
Copy link
Member

We will need changelog, because it includes multiple other changes

@oleg-nenashev oleg-nenashev changed the title Remove Stapler's Guava dependency [JENKINS-65442] - Improve performance when encoding unicode characters in JSON API + Remove Stapler's Guava dependency May 8, 2021
@oleg-nenashev
Copy link
Member

@basil please review the suggested changelog. It would be also great if you could keep the pull request template in your pull requests.

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 8, 2021
@basil
Copy link
Member Author

basil commented May 8, 2021

Sorry! I normally do that, but I had repurposed this PR for something other than its original purpose and had forgotten to update the description. I just updated it now to conform to the template.

@timja timja merged commit ceffaf5 into jenkinsci:master May 11, 2021
@basil basil deleted the stapler-guava branch September 5, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted squash-merge-me Unclean or useless commit history, should be merged only with squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants