Handle new guava version (vendor class)#85
Merged
bitwiseman merged 6 commits intojenkinsci:masterfrom Mar 16, 2021
Merged
Conversation
basil
approved these changes
Mar 14, 2021
car-roll
approved these changes
Mar 15, 2021
jglick
requested changes
Mar 15, 2021
| * the License. | ||
| */ | ||
|
|
||
| package jenkins.scm.api; |
Member
There was a problem hiding this comment.
Do not put this in the API package.
jglick
approved these changes
Mar 15, 2021
Member
|
merge with |
|
@bitwiseman do you have merge permissions? |
Member
Author
|
@car-roll I fixed your permissions, I've moved away from vendoring in here and used reflection, there was a lot of classes. FTR it's still not out of beta in latest master: google/guava#3423 |
Member
Author
bitwiseman
approved these changes
Mar 16, 2021
Member
Author
|
could someone merge and release? |
Member
|
FYI this still needs a release I think. |
10 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to jenkinsci/bom#423
cc @basil @dwnusbaum @car-roll @jglick @bitwiseman