Bump baseline, remove pointless test breaking CI #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
dwnusbaum
approved these changes
Mar 16, 2021
Contributor
car-roll
approved these changes
Mar 17, 2021
car-roll
left a comment
car-roll
left a comment
There was a problem hiding this comment.
Looks fine outside of what @bitwiseman said, the MessagesTest classes appear to already be removed
Member
Author
|
Yes in case anyone had issues with the other PR this one could have been merged first but all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to jenkinsci/branch-api-plugin#242, blocks #85
Messages are excluded from coverage in the parent pom: https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L1081
This broke when coverage was enabled by default, I dug into it a bit last time but couldn't see a fix other than removing it, which seems correct anyway