Skip to content

Conversation

@timja
Copy link
Member

@timja timja commented Mar 14, 2021

* the License.
*/

package jenkins.scm.api;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not put this in the API package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

@timja timja requested a review from jglick March 15, 2021 21:51
@jglick
Copy link
Member

jglick commented Mar 15, 2021

merge with master

@car-roll
Copy link

@bitwiseman do you have merge permissions?

@timja
Copy link
Member Author

timja commented Mar 15, 2021

@car-roll I fixed your permissions,

I've moved away from vendoring in here and used reflection, there was a lot of classes.
We could shade it if required: https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-if-i-want-to-use-beta-apis-from-a-library-that-people-use-as-a-dependency

FTR it's still not out of beta in latest master: google/guava#3423

@timja
Copy link
Member Author

timja commented Mar 16, 2021

@dwnusbaum

@timja
Copy link
Member Author

timja commented Mar 16, 2021

could someone merge and release?

@bitwiseman bitwiseman merged commit d01f419 into jenkinsci:master Mar 16, 2021
@timja timja deleted the handle-new-guava branch March 17, 2021 07:11
@basil
Copy link
Member

basil commented May 7, 2021

FYI this still needs a release I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants