-
-
Notifications
You must be signed in to change notification settings - Fork 86
Handle new guava version (vendor class) #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * the License. | ||
| */ | ||
|
|
||
| package jenkins.scm.api; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not put this in the API package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved
|
merge with |
|
@bitwiseman do you have merge permissions? |
|
@car-roll I fixed your permissions, I've moved away from vendoring in here and used reflection, there was a lot of classes. FTR it's still not out of beta in latest master: google/guava#3423 |
|
could someone merge and release? |
|
FYI this still needs a release I think. |
related to jenkinsci/bom#423
cc @basil @dwnusbaum @car-roll @jglick @bitwiseman