Skip to content

Conversation

@jtnord
Copy link
Member

@jtnord jtnord commented Sep 30, 2022

fixes #380

amends #320

@jglick @raul-arabaolaza

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@imonteroperez imonteroperez merged commit 13ed8c2 into jenkinsci:master Sep 30, 2022
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifact size should not increase much from this as the biggest by far was the CLI due to its shaded deps.

<artifactId>maven-deploy-plugin</artifactId>
<inherited>false</inherited>
<configuration>
<skip>true</skip>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless to not skip, since the module POMs will be flattened, but harmless enough to publish.

@jglick jglick mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

artifacts are not published to releases repo (except the cli)

4 participants