Skip to content

Conversation

@jtnord
Copy link
Contributor

@jtnord jtnord commented Sep 30, 2022

only the cli has been published to releases recently. I have no access to the workflow for CD (github is having issues) but I am assuming as there are multiple files that antifactory has multiple different secrets, yet only one is available for use by them github action, causing all modules to fail.

was not the cause of the issue - however it may be required to fix the issue (not sure wrt publishing multi module repos in CD)

compare
https://repo.jenkins-ci.org/artifactory/releases/org/jenkins-ci/tests/plugins-compat-tester-cli/

and
https://repo.jenkins-ci.org/artifactory/releases/org/jenkins-ci/tests/plugins-compat-tester-model/

@jglick @raul-arabaolaza

Description

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

only the cli has been published to releases recently.  I have no access
to the workflow for CD (github is having issues) but I am assuming as there are multiple files
that artifactory has multiple different secrets, yet only one is
available for use by theh github action, causing all modules to fail.

compare
https://repo.jenkins-ci.org/artifactory/releases/org/jenkins-ci/tests/plugins-compat-tester-cli/

and
https://repo.jenkins-ci.org/artifactory/releases/org/jenkins-ci/tests/plugins-compat-tester-model/
@jtnord jtnord requested a review from a team as a code owner September 30, 2022 10:13
@jtnord
Copy link
Contributor Author

jtnord commented Sep 30, 2022

may or may not be required for jenkinsci/plugin-compat-tester#381 (I am not fully clear on how multi-modul repos are supposed to work with cd here)

@timja timja merged commit c8e1d97 into jenkins-infra:master Sep 30, 2022
@jglick
Copy link
Contributor

jglick commented Sep 30, 2022

I am not fully clear on how multi-module repos are supposed to work with cd

I do not think anyone is. For historical reasons, the current logic does not handle multimodule repos well. The file structure needs to be reorganized (IMO) to be by repo rather than artifact. I have a full analysis of the code paths that just work by accident in some comment in some PR in this repo which I could search for if someone is interested. CC @daniel-beck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants