Skip to content

Migrate tests to JUnit5 #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mPokornyETM merged 2 commits into from
Oct 13, 2025
Merged

Migrate tests to JUnit5 #805

mPokornyETM merged 2 commits into from
Oct 13, 2025

Conversation

@strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Aug 12, 2025

With jenkinsci/jenkins-test-harness#988 being available now, the last remianing test can be migrated.

  • Use JenkinsSessionExtension
  • Minor code cleanup

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@strangelookingnerd
Migrate tests to JUnit5
c3a4450 
* Use JenkinsSessionExtension
* Minor code cleanup
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner August 12, 2025 08:03
@coderabbitai coderabbitai bot mentioned this pull request Aug 13, 2025
Merged
@mPokornyETM mPokornyETM added chore Maintenance test labels Oct 12, 2025
@mPokornyETM mPokornyETM added this to the Feature committed milestone Oct 12, 2025
mPokornyETM
mPokornyETM approved these changes Oct 12, 2025
View reviewed changes
Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mPokornyETM mPokornyETM enabled auto-merge (squash) October 12, 2025 19:28
@mPokornyETM mPokornyETM merged commit 7f7b69f into jenkinsci:master Oct 13, 2025
17 checks passed
@strangelookingnerd strangelookingnerd deleted the migrate_to_junit5 branch October 13, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mPokornyETM mPokornyETM mPokornyETM approved these changes

Assignees

No one assigned

Labels

chore Maintenance test

Projects

None yet

Milestone

Feature committed

Development

Successfully merging this pull request may close these issues.

2 participants

@strangelookingnerd @mPokornyETM