Skip to content

Set the HostPathVolume name to the normalized host path instead of volume-x #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonasScharpf wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Set the HostPathVolume name to the normalized host path instead of volume-x #2808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b7d111
Set the HostPathVolume name to the normalized host path instead of vo…
JonasScharpf Feb 4, 2026
358351f
Ensure the requirement of a lowercase RFC 1123 label at HostPathVolum…
JonasScharpf Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ public Pod build() {
String podName = agent.getPodName();
int i = 0;
for (final PodVolume volume : template.getVolumes()) {
final String volumeName = "volume-" + i;
final String volumeName = (volume instanceof HostPathVolume hp)
? normalizePath(hp.getHostPath()).replaceFirst("^/", "").replaceAll("[^a-zA-Z0-9-]", "-")
: "volume-" + i;
final String mountPath = normalizePath(volume.getMountPath());
if (!volumeMounts.containsKey(mountPath)) {
VolumeMountBuilder volumeMountBuilder = new VolumeMountBuilder() //
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ private void validatePod(Pod pod, boolean fromYaml, boolean directConnection) {
assertNotNull(volumes.get("empty-volume"));
assertNotNull(volumes.get("host-volume"));
} else {
assertNotNull(volumes.get("volume-0"));
assertNotNull(volumes.get("host-data"));
assertNotNull(volumes.get("volume-1"));
}

Expand Down Expand Up @@ -427,7 +427,7 @@ private void validatePod(Pod pod, boolean fromYaml, boolean directConnection) {
equalTo(
new VolumeMountBuilder() //
.withMountPath("/container/data")
.withName("volume-0")
.withName("host-data")
.withReadOnly(false)
.build()),
equalTo(
Expand Down