Set the HostPathVolume name to the normalized host path instead of volume-x#2808
Open
JonasScharpf wants to merge 2 commits intojenkinsci:masterfrom
Conversation
…lume-x This ensures the name of a HostPathVolume is known apriori and static. Previously the name was "volume-x" with x as a non static number, which might change when adding or removing volumes of a pod. The name of the HostPathVolume is the specified normalized host path and its "/" being replaced by "-". A host path like "/mnt/my/path/on-a_host" will generate the HostPathVolume name as "mnt-my-path-on-a_host"
…e if fullfilled This commit does change the HostPathVolume name to only consist of lower case alphanumeric characters or '-'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the name of a
HostPathVolumeis known a priori and static. Previously the name wasvolume-xwith x as a non static number, which might change when adding or removing volumes of a pod.The name of the
HostPathVolumeis the specified normalized host path and its/being replaced by-. A host path like/mnt/my/path/on-a_hostwill generate theHostPathVolumename asmnt-my-path-on-a_hostTesting done
The plugin has been build and deployed to my Jenkins instance. The plugin config output has been validated by printing the raw YAML to the console.
All unit tests have been successfully executed on my machine.
Submitter checklist
Ensure that the pull request title represents the desired changelog entry