Skip to content

Upgrade kubernetes-client-api to 6.8.1 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtnord merged 8 commits into from
Sep 4, 2023
Merged

Upgrade kubernetes-client-api to 6.8.1 #78

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd716d0
bump to 6.8.1 and add snakeyaml dependency
julieheard Aug 17, 2023
52d7125
Update snakeyaml to incremental version
julieheard Aug 22, 2023
7839219
Remove snakeyaml-api dependency
julieheard Aug 29, 2023
f1ea817
Updated to proper version of kubernetes-client-api-plugin
julieheard Aug 29, 2023
3e5417e
bump the jenkins version
julieheard Aug 29, 2023
7e8f7be
fix dependencies
julieheard Aug 29, 2023
81824db
move temp dependencies and update to plugins 4.73
julieheard Sep 4, 2023
bc297c8
upgrade to 2.414 and remove additional dependencies
julieheard Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.65</version>
<version>4.72</version>
<relativePath />
</parent>

Expand All @@ -45,8 +45,8 @@
<properties>
<revision>1</revision>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.361.4</jenkins.version>
<bom>2.361.x</bom>
<jenkins.version>2.401.1</jenkins.version>
<bom>2.401.x</bom>
<junit5.version>5.7.2</junit5.version>
</properties>

Expand Down Expand Up @@ -88,14 +88,14 @@
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp-bom</artifactId>
<!-- needs to be aligned with the version of okhttp-api in the plugin bom -->
<version>4.10.0</version>
<version>4.11.0</version>
<scope>import</scope>
<type>pom</type>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-bom</artifactId>
<version>1.8.21</version>
<version>1.9.10</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down Expand Up @@ -141,7 +141,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>kubernetes-client-api</artifactId>
<version>6.3.1-206.v76d3b_6b_14db_b</version>
<version>6.8.1-224.vd388fca_4db_3b_</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
Expand Down Expand Up @@ -234,14 +234,29 @@
</exclusion>
</exclusions>
</dependency>

<!-- static analysis -->
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-annotations</artifactId>
<scope>provided</scope>
<optional>true</optional>
</dependency>

<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>bouncycastle-api</artifactId>
<version>2.29</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>jackson2-api</artifactId>
<version>2.15.2-350.v0c2f3f8fc595</version>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>okhttp-api</artifactId>
<version>4.11.0-157.v6852a_a_fa_ec11</version>
</dependency>
Copy link
Member

@jtnord jtnord Sep 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin does not depend on these and so they should not be needed. What is the rationale for the the creep in dependencies?

Due to the Jenkins bump I have also bumped Kotlin and included three new dependencies (bouncycastle-api, jackson2-api, okhttp-api) as they were creating RequireUpperBoundDeps errors.

perhaps you just need to pickup a newer bom version, at any rate - they are not plugin dependencies so should not be added to the dependencies section, rather dependencyManagement if they are not available in a newer bom

</dependencies>

<!-- Jenkins is not synced to central so we need to bootstrap -->
Expand Down