-
-
Notifications
You must be signed in to change notification settings - Fork 73
Upgrade kubernetes-client-api to 6.8.1 #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Robert Sandell <rsandell@cloudbees.com>
|
Just need to remember to update to the "real" version when it is released. |
|
@julieheard Need to bump |
|
@julieheard I can't update this PR so you need to fix it. |
|
I am on it, when testing locally it also wants bumps for bouncycastle-api:2.27, okhttp-api:4.10.0-132.v7a_7b_91cef39c and jackson2-api:2.15.1-344.v6eb_55303dc3e |
|
Due to the Jenkins bump I have also bumped Kotlin and included three new dependencies (bouncycastle-api, jackson2-api, okhttp-api) as they were creating RequireUpperBoundDeps errors. I came accross a strange issue with a test, Digging into this I think it is a conflict between junit and hamcrest, I do not think it is due to the changes made in this PR. |
Can't reproduce on my side, and I only see one hamcrest copy in the classpath |
|
I have re-ran this test quite a few times today and also now can't reproduce. Must have been a small glitch in the classpath or something silly. This PR is now ready to merge 🙂 @agentgonzo or @jtnord would you mind merging as the upstream PR has now been merged? Many thanks 🙂 |
|
Any update there ? Is confusing to have the kubernetes-api client available for upgrade but not all consumer upgraded. Specially for people upgrading regulary their Jenkins plugins. Thanks! |
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>bouncycastle-api</artifactId> | ||
| <version>2.29</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>jackson2-api</artifactId> | ||
| <version>2.15.2-350.v0c2f3f8fc595</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>okhttp-api</artifactId> | ||
| <version>4.11.0-157.v6852a_a_fa_ec11</version> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin does not depend on these and so they should not be needed. What is the rationale for the the creep in dependencies?
Due to the Jenkins bump I have also bumped Kotlin and included three new dependencies (bouncycastle-api, jackson2-api, okhttp-api) as they were creating RequireUpperBoundDeps errors.
perhaps you just need to pickup a newer bom version, at any rate - they are not plugin dependencies so should not be added to the dependencies section, rather dependencyManagement if they are not available in a newer bom
Downstream of jenkinsci/kubernetes-client-api-plugin#221
Testing done
I ran mvn verify to test locally and all working, all tests passing