Skip to content

Use modern jenkins-table to list attachments #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglick merged 1 commit into from
May 26, 2022
Merged

Use modern jenkins-table to list attachments #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<properties>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.289.1</jenkins.version>
<jenkins.version>2.332.3</jenkins.version>
Copy link
Member

@jglick jglick May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason to use 2.332.3 rather than 2.332.1? https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/#choosing-a-version

Copy link
Member Author

@NotMyFault NotMyFault May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I somehow had in mind that the latest point release of an LTS version is the desired version.
If needed, we can use .1 here, the relevant change has been introduced in 2.321 iirc.

Copy link
Member

@jglick jglick May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went back and forth but this was the compromise position from jenkins-infra/jenkins.io#4876.

Copy link
Member Author

@NotMyFault NotMyFault May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oic, thanks for the clarification.

<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
</properties>

Expand All @@ -44,8 +44,8 @@
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.289.x</artifactId>
<version>1289.v5c4b_1c43511b_</version>
<artifactId>bom-2.332.x</artifactId>
<version>1382.v7d694476f340</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
13 changes: 7 additions & 6 deletions src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define"
xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
<j:jelly xmlns:j="jelly:core">

<tr><td>
<h3>${%Attachments}</h3>
<table class="pane" id="attachments">
<tr>
<td class="pane-header">${%Files}</td>
</tr>
<table class="jenkins-table" id="attachments">
<thead>
<tr>
<th class="pane-header">${%Files}</th>
</tr>
</thead>
<j:forEach var="attachment" items="${it.attachments}">
<tr>
<td class="pane">
Expand Down