Use modern jenkins-table to list attachments
#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
May 26, 2022
jglick
reviewed
May 27, 2022
| <properties> | ||
| <changelist>999999-SNAPSHOT</changelist> | ||
| <jenkins.version>2.289.1</jenkins.version> | ||
| <jenkins.version>2.332.3</jenkins.version> |
Member
There was a problem hiding this comment.
Was there a specific reason to use 2.332.3 rather than 2.332.1? https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/#choosing-a-version
Member
Author
There was a problem hiding this comment.
Not really, I somehow had in mind that the latest point release of an LTS version is the desired version.
If needed, we can use .1 here, the relevant change has been introduced in 2.321 iirc.
Member
There was a problem hiding this comment.
We went back and forth but this was the compromise position from jenkins-infra/jenkins.io#4876.
Member
Author
There was a problem hiding this comment.
Oic, thanks for the clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change proposed utilizes the
jenkins-tabletag to align the attachments table with the layout of other modern tables of the Jenkins UI.Current layout:
Proposed change:
The plugin is labeled as up for adoption, but maybe you want to take a look nevertheless @jglick.