Skip to content

Deprecating Run.getLogFile #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglick merged 2 commits into from
Apr 3, 2019
Merged

Deprecating Run.getLogFile #3963

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
870eafe
Deprecating Run.getLogFile.
jglick Apr 2, 2019
6ddedfe
Better wording for deprecation notice.
dwnusbaum Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/java/hudson/model/Run.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,7 +1429,9 @@ public Collection<Fingerprint> getBuildFingerprints() {
/**
* Returns the log file.
* @return The file may reference both uncompressed or compressed logs
*/
* @deprecated Assumes file-based storage of the log, which is not necessarily the case for Pipelines after JEP-210. Use other methods giving various kinds of streams such as {@link Run#getLogReader()}, {@link Run#getLogInputStream()}, or {@link Run#getLogText()}.
*/
@Deprecated
public @Nonnull File getLogFile() {
File rawF = new File(getRootDir(), "log");
if (rawF.isFile()) {
Expand Down